Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation for remoulade #1082

Merged
merged 39 commits into from
May 31, 2022
Merged

Add instrumentation for remoulade #1082

merged 39 commits into from
May 31, 2022

Conversation

ben-natan
Copy link
Contributor

@ben-natan ben-natan commented May 3, 2022 •
edited
Loading

Description

This adds instrumentation support for remoulade, in roughly the same way Celery does.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • We are using this implementation internally

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ben-natan ben-natan requested a review from a team May 3, 2022 15:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lzchen
Copy link
Contributor

lzchen commented May 9, 2022

@ben-natan
Following the contributing guidelines, would you be willing to be a codeowner for this package?

@ben-natan
Copy link
Contributor Author

@machine424 and I are willing to be codeowners for this package

srikanthccv
srikanthccv reviewed May 19, 2022
View reviewed changes
...ntelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py Outdated Show resolved Hide resolved
...ntelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py Outdated Show resolved Hide resolved
...ntelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py Outdated Show resolved Hide resolved
...ntelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py Outdated Show resolved Hide resolved
...ntelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/__init__.py Outdated Show resolved Hide resolved
...entelemetry-instrumentation-remoulade/src/opentelemetry/instrumentation/remoulade/version.py Outdated Show resolved Hide resolved
@lzchen
Copy link
Contributor

lzchen commented May 19, 2022

@ben-natan

Please add yourself to component-owners

@ben-natan
Copy link
Contributor Author

ben-natan commented May 20, 2022 •
edited
Loading

I intentionally excluded instrumentation-remoulade from pypy3 because remoulade does not support pypy3.6

@lzchen lzchen merged commit 5f7c293 into open-telemetry:main May 31, 2022
@ben-natan ben-natan deleted the add-remoulade branch June 30, 2022 13:02
@srikanthccv srikanthccv mentioned this pull request Aug 29, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxeye-nikolay oxeye-nikolay oxeye-nikolay approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@sanketmehta28 sanketmehta28 sanketmehta28 approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@machine424 machine424

@ben-natan ben-natan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ben-natan @lzchen @srikanthccv @machine424 @sanketmehta28 @oxeye-nikolay