Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requests span attributes available to samplers for http instrumentations #936

Open
5 of 7 tasks
lzchen opened this issue Mar 1, 2022 · 10 comments
Open
5 of 7 tasks
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lzchen
Copy link
Contributor

lzchen commented Mar 1, 2022

@lzchen lzchen added the bug Something isn't working label Mar 1, 2022
@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 2, 2022
@srikanthccv
Copy link
Member

@codeboten this should supported for the http server instrumentations also right?

@nstawski
Copy link
Contributor

nstawski commented Apr 7, 2022

I would like to take this issue.

@lzchen
Copy link
Contributor Author

lzchen commented Apr 11, 2022

@nstawski
Feel free to comment on the instrumentation issues so we can assign them individually.

@cheempz
Copy link

cheempz commented Mar 22, 2023

@lzchen @srikanthccv could you confirm that this issue can be understood as "Make HTTP span attributes available to samplers", i.e. would apply to both Client and Server attributes that have been called out by the semantic conventions for HTTP spans to be available at sampling time:

Common

Following attributes MUST be provided at span creation time (when provided at all), so they can be considered for sampling decisions:

http.method

Client

Following attributes MUST be provided at span creation time (when provided at all), so they can be considered for sampling decisions:

http.url
net.peer.name
net.peer.port

Server

Following attributes MUST be provided at span creation time (when provided at all), so they can be considered for sampling decisions:

http.target
http.scheme
net.host.name
net.host.port

This is something we're grappling with and would really help our approach to get a confirmation. Thanks!

@srikanthccv
Copy link
Member

could you confirm that this issue can be understood as "Make HTTP span attributes available to samplers", i.e. would apply to both Client and Server attributes that have been called out by the semantic conventions for HTTP spans to be available at sampling time:

Yes, the issue description confirms it as there are both HTTP client and server instrumentations listed.

@cheempz
Copy link

cheempz commented Mar 22, 2023

@nstawski is this still on your radar? We'd love to see these server instrumentation changes!

@nstawski
Copy link
Contributor

nstawski commented Mar 22, 2023 via email

@cheempz
Copy link

cheempz commented Mar 22, 2023

It is. I am out on maternity leave until end of April and can pick this up once I am back. Let me know if the timing works.

That would be fantastic @nstawski, thank you :)

@tammy-baylis-swi
Copy link
Contributor

Could we add an additional issue for opentelemetry-instrumentation-asgi? I'd be happy to take that one.

@tammy-baylis-swi
Copy link
Contributor

Hi again, could we add another issue for opentelemetry-instrumentation-flask? I'd like to take that one too. The change is probably similar to the recent Django update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants