Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating redis instrumentation to use instrumentor interface #38

Closed
codeboten opened this issue Apr 15, 2020 · 1 comment
Closed

Updating redis instrumentation to use instrumentor interface #38

codeboten opened this issue Apr 15, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

Currently the redis instrumentation documents using the patch interface directly, this should be updated once this issue is resolved: open-telemetry/opentelemetry-python#554

Here's documentation:
https://github.com/open-telemetry/opentelemetry-python-contrib/pull/21/files/676c3499819fcab55d0de47c7ef8555f81bb0894#diff-a42497cde4dba9f19c87f87a001c4cc8R28
@codeboten codeboten added the bug Something isn't working label Apr 15, 2020
@codeboten codeboten mentioned this issue Apr 15, 2020
Closed
@mauriciovasquezbernal
Copy link
Member

Solved by open-telemetry/opentelemetry-python#595.

NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this issue Oct 17, 2020
@Oberon00
Misc build improvements (build docs & more) (open-telemetry#38)
826346f 
* Build docs.

* Minor tox.ini improvements.

* .gitignore mypy

* Fix doc build.

* Tell travis to build docs (with 3.7).
NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this issue Oct 20, 2020
@Oberon00
Misc build improvements (build docs & more) (open-telemetry#38)
ab563ee 
* Build docs.

* Minor tox.ini improvements.

* .gitignore mypy

* Fix doc build.

* Tell travis to build docs (with 3.7).
NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this issue Nov 23, 2020
@Oberon00
Misc build improvements (build docs & more) (open-telemetry#38)
922544b 
* Build docs.

* Minor tox.ini improvements.

* .gitignore mypy

* Fix doc build.

* Tell travis to build docs (with 3.7).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @mauriciovasquezbernal