Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tracestate to an unstructured raw string field #57

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Convert tracestate to an unstructured raw string field #57

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f69db3
Convert tracestate to an unstructured raw string field
Nov 15, 2019
064e337
Merge branch 'master' into feature/tigran/tracestate
yurishkuro Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 6 additions & 25 deletions opentelemetry/proto/trace/v1/trace.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,29 +54,10 @@ message Span {
// This field is required.
bytes span_id = 2;

// This field conveys information about request position in multiple distributed tracing graphs.
// It is a list of Tracestate.Entry with a maximum of 32 members in the list.
//
// See the https://github.com/w3c/distributed-tracing for more details about this field.
message Tracestate {
message Entry {
// The key must begin with a lowercase letter, and can only contain
// lowercase letters 'a'-'z', digits '0'-'9', underscores '_', dashes
// '-', asterisks '*', and forward slashes '/'.
string key = 1;

// The value is opaque string up to 256 characters printable ASCII
// RFC0020 characters (i.e., the range 0x20 to 0x7E) except ',' and '='.
// Note that this also excludes tabs, newlines, carriage returns, etc.
string value = 2;
}

// A list of entries that represent the Tracestate.
repeated Entry entries = 1;
}

// The Tracestate on the span.
Tracestate tracestate = 3;
// tracestate conveys information about request position in multiple distributed tracing graphs.
// It is a tracestate in w3c-trace-context format: https://www.w3.org/TR/trace-context/#tracestate-header
// See also https://github.com/w3c/distributed-tracing for more details about this field.
string tracestate = 3;

// The `span_id` of this span's parent span. If this is a root span, then this
// field must be empty. The ID is an 8-byte array.
Expand Down Expand Up @@ -203,8 +184,8 @@ message Span {
// A unique identifier for the linked span. The ID is an 8-byte array.
bytes span_id = 2;

// The Tracestate associated with the link.
Tracestate tracestate = 3;
// The tracestate associated with the link.
string tracestate = 3;

// attributes is a collection of attribute key/value pairs on the link.
repeated opentelemetry.proto.common.v1.AttributeKeyValue attributes = 4;
Expand Down