Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: fix versioning in selector #551

Merged
merged 1 commit into from
Apr 25, 2024
Merged

profiles: fix versioning in selector #551

merged 1 commit into from
Apr 25, 2024

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Apr 25, 2024 •
edited
Loading

Creating Go dependencies for the Profiles signal fails, as the selector uses v1 instead of v1experimental.

$ docker run --rm -u 1000 -v/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go:/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go -w/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go otel/build-protobuf:0.23.0 --proto_path="gen/proto" --grpc-gateway_out=logtostderr=true,grpc_api_configuration=opentelemetry-proto/opentelemetry/proto/collector/profiles/v1experimental/profiles_service_http.yaml:./gen/go --go_out=./gen/go --go-grpc_out=./gen/go gen/proto/opentelemetry/proto/collector/profiles/v1experimental/profiles_service.proto
--grpc-gateway_out: HTTP rules without a matching selector: .opentelemetry.proto.collector.profiles.v1.ProfilesService.Export

I noticed this issue while working on open-telemetry/opentelemetry-proto-go#166.

@florianl florianl requested a review from a team April 25, 2024 07:11
@florianl
Copy link
Contributor Author

FYI @open-telemetry/profiling-maintainers

@dmathieu dmathieu mentioned this pull request Apr 25, 2024
Merged
felixge
felixge approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

tigrannajaryan
tigrannajaryan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't the build fail before this fix?

@tigrannajaryan
Copy link
Member

Why didn't the build fail before this fix?

Nevermind, I see #552 adds a check.

@tigrannajaryan tigrannajaryan merged commit a40cafc into open-telemetry:main Apr 25, 2024
16 checks passed
@florianl florianl deleted the patch-1 branch April 25, 2024 17:01
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@florianl @VinozzZ
profiles: fix versioning in selector (open-telemetry#551)
34b3e91
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@florianl @VinozzZ
profiles: fix versioning in selector (open-telemetry#551)
7b108a8
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@florianl @VinozzZ
profiles: fix versioning in selector (open-telemetry#551)
63c94a1
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this pull request Jun 21, 2024
@florianl @VinozzZ
profiles: fix versioning in selector (open-telemetry#551)
da06c61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@felixge felixge felixge approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@florianl @tigrannajaryan @dmathieu @felixge @bogdandrutu