Refine descriptions of Histogram+Summary for explicit OpenMetrics compat #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility Fixes open-telemetry#187. - Summary data points must record non-negative values - Histogram sum can only be present if underlying measurements are non-negative. (Opening a bug to expand our API to allow this to present in more scenarios later)
bogdandrutu
approved these changes
May 10, 2021
jmacd
approved these changes
May 10, 2021
Co-authored-by: Joshua MacDonald <[email protected]>
|
@bogdandrutu Updated the in-proto comments about open metrics (in addition to the PR commit title) |
jmacd
approved these changes
May 11, 2021
bogdandrutu
reviewed
May 11, 2021
bogdandrutu
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
Fixes open-telemetry/prometheus-interoperability-spec#21