Add schema_url fields as described in OTEP 0152 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmoto
approved these changes
Apr 30, 2021
jmacd
approved these changes
May 1, 2021
bogdandrutu
reviewed
May 3, 2021
jsuereth
approved these changes
May 3, 2021
|
I have just chatted with @bogdandrutu and he had some ideas that may result in putting schema_url inside InstrumentationLibrary message instead of InstrumentationLibraryXXX message (no difference in semantics). |
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
5ad3f14
to
dd92c01
Compare
|
Reviewers, please have another look. I will keep this open for 2 days just in case there are objections to the last change. |
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 6, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: - Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 6, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: - Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 6, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: - Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 6, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 6, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message. This is the first in the series of changes that are necessary to add support for schemas in Go SDK. Subsequent PRs will add support in Meter and Resource. We will also see if we can find a good way to group semantic conventions with the schema version that declares them.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 7, 2021
This adds to the API and SDK the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 7, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message. This is the first in the series of changes that are necessary to add support for schemas in Go SDK. Subsequent PRs will add support in Meter and Resource. We will also see if we can find a good way to group semantic conventions with the schema version that declares them.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 11, 2021
This adds to the API and SDK the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
dd92c01
to
7f51f7f
Compare
Aneurysm9
approved these changes
May 11, 2021
MrAlias
approved these changes
May 11, 2021
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
7f51f7f
to
9302195
Compare
jmacd
approved these changes
May 11, 2021
gramidt
approved these changes
May 11, 2021
jsuereth
approved these changes
May 12, 2021
This adds schema_url fields introduced in OTEP 0152 (Telemetry Schemas): https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md#otlp-changes
…chema_url" in the nested messages
tigrannajaryan
force-pushed
the
feature/tigran/add-schema-url
branch
from
9302195
to
55377f9
Compare
|
@tigrannajaryan Do you want this to merge and release in v0.9? The metrics group would like to release v0.9 very soon. Thanks! |
|
We have the necessary number of approvals and all comments are resolved, so merging. |
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 12, 2021
This adds to the API and SDK the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 14, 2021
This adds to the API and SDK the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 17, 2021
This adds to the API the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
May 18, 2021
This adds to the API the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
May 18, 2021
This adds to the API the changes proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Corresponding changes to the proto repository are here: open-telemetry/opentelemetry-proto#298
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-go
that referenced
this pull request
May 19, 2021
[Do not merge, this is a draft to get maintainers' feedback] This adds support for schema URL according to the specification: open-telemetry/opentelemetry-specification#1666 (Link to replaced by the link to the spec after that PR is merged) TODO: Populate the schema_url field in the OTLP after this PR open-telemetry/opentelemetry-proto#298 is merged and the field is available in the proto message. This is the first in the series of changes that are necessary to add support for schemas in Go SDK. Subsequent PRs will add support in Meter and Resource. We will also see if we can find a good way to group semantic conventions with the schema version that declares them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds schema_url fields introduced in OTEP 0152 (Telemetry Schemas):
https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md#otlp-changes