Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change traces enum values to follow protobuf style #198

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

bogdandrutu
Copy link
Member

Following the style guide from https://developers.google.com/protocol-buffers/docs/style#enums
There is a small caveat in golang golang/protobuf#513

Updates #131

@bogdandrutu bogdandrutu requested review from a team August 6, 2020 21:28
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit ca6dcbb into open-telemetry:master Aug 10, 2020
@bogdandrutu bogdandrutu deleted the enumtrace branch February 1, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants