Add protocol to Metric Configuration Service #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
previously requested changes
Jul 29, 2020
bogdandrutu
dismissed
their stale review
I pressed the magic button to update the branch and things are good now
|
@bogdandrutu Great thanks! The local setup was a little weird, since we based our changes off the 0.4.0 release to avoid dependency problems in our prototypes. Sorry I missed your earlier message! I went ahead and straightened out the history for this PR and force-pushed the changes. |
anuraaga
reviewed
Jul 30, 2020
Comment on lines
26
to
27
| // MetricConfig is a service that enables updating metric schedules, trace | ||
| // parameters, and other configurations on the SDK without having to restart the |
There was a problem hiding this comment.
Suggested change
| // MetricConfig is a service that enables updating metric schedules, trace | |
| // parameters, and other configurations on the SDK without having to restart the | |
| // MetricConfig is a service that enables updating metric schedules and other configurations on the SDK without having to restart the |
Looks like the scope was narrowed to just metrics which makes sense
bogdandrutu
reviewed
Aug 6, 2020
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package opentelemetry.proto.experimental.metricconfigservice; |
There was a problem hiding this comment.
add this in:
"experimental/metrics/configservice"
SergeyKanzhelev
approved these changes
Aug 12, 2020
|
Thank you for initiating the experimental folder! |
jmacd
approved these changes
Aug 13, 2020
bogdandrutu
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Goal
We introduce a new protocol for dynamically configuring metric collection schedules. It follows from this OTEP.
An example implementation is almost completed and will be sent to the collector-contrib and go-contrib repos. In the meantime, we'd love to hear your thoughts on this protocol and the related specification!
About
We're an intern group at Google. Members include: