Generated protofiles based on v0.7.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Mar 3, 2021
| @@ -0,0 +1,10 @@ | |||
| module go.opentelemetry.io/proto/otlp | |||
There was a problem hiding this comment.
Do we use vanity url for this repo? I don't see go.opentelemetry.io/proto enabled.
There was a problem hiding this comment.
Not yet. I was waiting until there is usable logic in this repository to enable that URL.
Can we add these as a github action that verifies that the result of the generation matches the content in the commit? |
|
Agreed, that is something that was planned. Tracked in #6 |
tigrannajaryan
approved these changes
Mar 3, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the generation of v0.7.0 of the Opentelemetry-proto repository.
commands to generated this: