Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct platform identifier for Apple Silicon / M1 docker images #961

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

cedricziel
Copy link
Contributor

Use correct arm64 platform for building docker images.

My previous PR in #960 used the wrong platform for M1/Apple silicon

Use correct arm64 platform for building docker images.

My previous PR in open-telemetry#960 used the wrong platform for M1/Apple silicon
@cedricziel cedricziel requested a review from a team April 5, 2023 19:13
@cedricziel cedricziel changed the title Update publish-otel-php-base-docker-image.yml Use correct platform identifier for Apple Silicon / M1 docker images Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #961 (af826a3) into main (72e9f56) will not change coverage.
The diff coverage is n/a.

❗ Current head af826a3 differs from pull request most recent head f62f28a. Consider uploading reports for the commit f62f28a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #961   +/-   ##
=========================================
  Coverage     83.34%   83.34%           
  Complexity     2126     2126           
=========================================
  Files           277      277           
  Lines          6105     6105           
=========================================
  Hits           5088     5088           
  Misses         1017     1017           
Flag Coverage Δ
7.4 81.98% <ø> (ø)
8.0 83.29% <ø> (ø)
8.1 83.42% <ø> (ø)
8.2 83.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e9f56...f62f28a. Read the comment docs.

@bobstrecansky bobstrecansky merged commit ca2df9f into open-telemetry:main Apr 5, 2023
@cedricziel cedricziel deleted the patch-1 branch April 5, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants