-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance README: Shields to capture the attention of potential contributors #1344
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea to me!
Hi @devactivity-team very happy to accept this PR thanks. We do need to have the CLA signed (see the bot comment above) before we can accept any contributions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
============================================
+ Coverage 74.61% 74.65% +0.04%
Complexity 2504 2504
============================================
Files 355 355
Lines 7180 7180
============================================
+ Hits 5357 5360 +3
+ Misses 1823 1820 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi @devactivity-team are you able to sign the CLA so that we can merge this? thanks :) |
Apologies for the delay. Done |
Thanks, it looks great! :) |
* 8.4: fixing some implicit nullable params * fix withspan handler nullable + example (#1377) - class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span * fix: update references to logging exporter (#1383) This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <[email protected]> * fix: Update collector tag in example to latest (#1384) Follow-up from #1383. Debug exporter isn't available until v0.86.0, so this new configuration throws an error when trying to run the collector. `Error: cannot unmarshal the configuration: unknown exporters type "debug" for "debug"` Instead of setting to v0.86.0, I noticed the other docker files omitted the tag (so latest is pulled). I just updated this to match. * Remove `MeterInterface::isEnabled()` and fix meter config re-enabling (#1387) * Update SPI dependency to v1. (#1388) * Fix README badges. (#1389) * add phpDocumentor instructions to Makefile (#1385) * add phpDocumentor instructions to Makefile Signed-off-by: svrnm <[email protected]> * update DEVELOPMENT.md Signed-off-by: svrnm <[email protected]> --------- Signed-off-by: svrnm <[email protected]> * Update README.md (#1344) * Fix `IncompatibleReturnValueException` in `MessageFactoryTest` (#1392) PSR7 `RequestInterface::getUri()` must return `UriInterface`, not `string`; explicit typehint was added in `2.0`. * more implicit nulls --------- Signed-off-by: Alex Boten <[email protected]> Signed-off-by: svrnm <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Jamie Danielson <[email protected]> Co-authored-by: Tobias Bachert <[email protected]> Co-authored-by: Chris Lightfoot-Wild <[email protected]> Co-authored-by: Severin Neumann <[email protected]> Co-authored-by: Oleg <[email protected]>
I noticed you have opened issues labeled
help wanted
. I recommend enhancing the README to make the call for new contributors more prominent.Changes Made:
Why This Matters:
Additional Resources:
For more insights into building a strong open-source community, check out the Building Community guide.
🚀 Thank you for considering this pull request! 🚀