chore(laravel): split shouldRecordLog method for easier override

open-telemetry · Oct 16, 2024 · 1760bef · 1760bef
1 parent 7a48cd9
commit 1760bef
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/Instrumentation/Laravel/composer.json b/src/Instrumentation/Laravel/composer.json
@@ -48,7 +48,8 @@
     "lock": false,
     "sort-packages": true,
     "allow-plugins": {
-      "php-http/discovery": false
+      "php-http/discovery": false,
+      "tbachert/spi": true
     }
   }
 }
diff --git a/src/Instrumentation/Laravel/src/Watchers/LogWatcher.php b/src/Instrumentation/Laravel/src/Watchers/LogWatcher.php
@@ -29,10 +29,7 @@ public function register(Application $app): void
         $this->logger = $app['log'];
     }
 
-    /**
-     * Record a log.
-     */
-    public function recordLog(MessageLogged $log): void
+    public function shouldRecordLog(MessageLogged $log): bool
     {
         $underlyingLogger = $this->logger->getLogger();
 
@@ -41,6 +38,18 @@ public function recordLog(MessageLogged $log): void
             && method_exists($underlyingLogger, 'toMonologLevel')
             && !$underlyingLogger->isHandling($underlyingLogger->toMonologLevel($log->level))
         ) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Record a log.
+     */
+    public function recordLog(MessageLogged $log): void
+    {
+        if (!$this->shouldRecordLog($log)) {
             return;
         }