Upgrade operator-sdk #982
Merged
Upgrade operator-sdk #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
|
@pavolloffay, @jpkrohling, could you please take a look? |
|
The scorecard images need to be upgraded as well |
Signed-off-by: Yuri Sa <[email protected]>
I've changed them. |
jpkrohling
reviewed
Jul 18, 2022
Makefile
Outdated
| $(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v3,v3.8.7) | ||
| kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary. | ||
| $(KUSTOMIZE): $(LOCALBIN) | ||
| curl -s $(KUSTOMIZE_INSTALL_SCRIPT) | bash -s -- $(subst v,,$(KUSTOMIZE_VERSION)) $(LOCALBIN) |
There was a problem hiding this comment.
is there another way of doing this without bash | curl? I myself frown upon this, as I would have to inspect the script before running this make target, instead of just looking at the Makefile
There was a problem hiding this comment.
I've followed the upgrade recommendations of operator-sdk; most likely, they are not so effective.
There was a problem hiding this comment.
I've rolled back to use the previous way with the v4 of kustomize.
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
jpkrohling
approved these changes
Jul 19, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Upgrading operator-sdk Signed-off-by: Yuri Sa <[email protected]> * Upgrading operator-sdk Signed-off-by: Yuri Sa <[email protected]> * Upgrading operator-sdk Signed-off-by: Yuri Sa <[email protected]> * Changing api docs Signed-off-by: Yuri Sa <[email protected]> * Changing annotations Signed-off-by: Yuri Sa <[email protected]> * Changing annotations Signed-off-by: Yuri Sa <[email protected]> * Upgrading scorecard version Signed-off-by: Yuri Sa <[email protected]> * Removing curl-bash commands and kustomization file changes Signed-off-by: Yuri Sa <[email protected]> * Removing curl-bash commands and kustomization file changes Signed-off-by: Yuri Sa <[email protected]> * Adding kube-rbac-proxy changes Signed-off-by: Yuri Sa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuri Sa [email protected]
Resolver #972