Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pod Mutation loop #953
Fix Pod Mutation loop #953
Changes from 9 commits
c7974da
cfb8b81
5acbe82
7f3989c
5dbafa7
b906f7d
b5f1cc1
99346db
1fdb631
08e0c1d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this check needed?
The
IsAutoInstrumentationInjected
is not enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
IsOtAIVolumeMissing
andIsEnvVarValueInstrumentationMissing
were applied before I've added check for pod mutation. When Pod was mutated few times k8s was throwing errors likeduplicated volume name
. In case of env var it happened that e.g.javaJVMArgument
was added few times toJAVA_TOOL_OPTIONS
. So I left this checks for safety for other unexpected mutations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to remove this and
IsEnvVarValueInstrumentationMissing
as well and rely only on the init container for simplicity.We should keep it here only if there is a known scenario which the init container does not cover