Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue that target-level metadata labels were missing (#948) #949

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Fix the issue that target-level metadata labels were missing (#948) #949

merged 2 commits into from
Jul 26, 2022

Conversation

CoderPoet
Copy link
Contributor

Fix the issue that target-level metadata labels were missing

  • keep target-level metadata Labels

@CoderPoet CoderPoet requested a review from a team June 26, 2022 15:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 26, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CoderPoet / name: Wen Hu (e078d85)

@yuriolisa
Copy link
Contributor

@CoderPoet, could you please sign your PR?

@CoderPoet
Copy link
Contributor Author

@CoderPoet, could you please sign your PR?

Thanks for the reminder, I used the wrong email address when I commited it before, so the SLA failed many times.

yuriolisa
yuriolisa approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@yuriolisa yuriolisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuriolisa
Copy link
Contributor

@Aneurysm9, could you please take a look?

@CoderPoet
Copy link
Contributor Author

@Aneurysm9, could you please take a look?

@Aneurysm9 PTAL 😁

@yuriolisa
Copy link
Contributor

@pavolloffay, @jpkrohling. PTAL.

@jpkrohling
Copy link
Member

@Aneurysm9, could you please assign someone to review this code here? It's apparently about the target allocator.

@jpkrohling jpkrohling merged commit ab00e8c into open-telemetry:main Jul 26, 2022
@secustor secustor mentioned this pull request Nov 3, 2022
Closed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@CoderPoet
Fix the issue that target-level metadata labels were missing (open-te…
66611e4 
…lemetry#948) (open-telemetry#949)

* Fix the issue that target-level metadata labels were missing (open-telemetry#948)

* fix(allocation): GetAllTargetsByCollectorAndJob with label merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@yuriolisa yuriolisa yuriolisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CoderPoet @yuriolisa @jpkrohling @Aneurysm9