Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments to reflect correct name of component #909

Closed
wants to merge 1 commit into from
Closed

Update comments to reflect correct name of component #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/otel-allocator/allocation/allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
)

/*
Load balancer will serve on an HTTP server exposing /jobs/<job_id>/targets <- these are configured using least connection
Load balancer will need information about the collectors in order to set the URLs
Target Allocator will serve on an HTTP server exposing /jobs/<job_id>/targets <- these are configured using least connection
Target Allocator will need information about the collectors in order to set the URLs
Keep a Map of what each collector currently holds and update it based on new scrape target updates
*/

Expand Down Expand Up @@ -65,7 +65,7 @@ func (allocator *Allocator) findNextCollector() *collector {
}

// SetTargets accepts the a list of targets that will be used to make
// load balancing decisions. This method should be called when where are
// target allocation decisions. This method should be called when where are
// new targets discovered or existing targets are shutdown.
func (allocator *Allocator) SetWaitingTargets(targets []TargetItem) {
// Dump old data
Expand Down
2 changes: 1 addition & 1 deletion cmd/otel-allocator/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (

// ErrInvalidYAML represents an error in the format of the original YAML configuration file.
var (
ErrInvalidYAML = errors.New("couldn't parse the loadbalancer configuration")
ErrInvalidYAML = errors.New("couldn't parse the targetallocator configuration")
)

const DefaultResyncTime = 5 * time.Minute
Expand Down