Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cert manager 1.8.0 #905

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Add cert manager 1.8.0 #905

merged 6 commits into from
Jun 8, 2022

Conversation

yuriolisa
Copy link
Contributor

Signed-off-by: Yuri Sa [[email protected]]

  • Modifying makefile to install cert-manager 1.8.0.
  • Adding on Compatibility Matrix this cert-manager version for the last release.

@yuriolisa yuriolisa requested a review from a team June 1, 2022 06:50
@yuriolisa
Copy link
Contributor Author

Close #888

@yuriolisa
Copy link
Contributor Author

@VineethReddy02

pavolloffay
pavolloffay reviewed Jun 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yuriolisa yuriolisa mentioned this pull request Jun 1, 2022
Closed
@yuriolisa yuriolisa requested a review from pavolloffay June 1, 2022 11:52
pavolloffay
pavolloffay reviewed Jun 1, 2022
View reviewed changes
README.md Outdated
| v0.36.0 | v1.20 to v1.22 | v1alpha2, v1alpha3 |
| v0.35.0 | v1.20 to v1.22 | v1alpha2, v1alpha3 |
| v0.34.0 | v1.20 to v1.22 | v1alpha2, v1alpha3 |
| v0.33.0 | v1.20 to v1.22 | v1alpha2, v1alpha3 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we actually tested 0.33.0 against e.g. the oldest version of cert-manager v1alpha3?

@yuriolisa
Copy link
Contributor Author

@pavolloffay, I'll keep only the v1alpha2 which is the default for cert-manager 1.6.3 due to :

  • the cert-manager compatibility for Kubernetes / Openshift versions.
  • we are testing only the versions 1.19 and 1.23.

https://cert-manager.io/docs/installation/supported-releases/#old-releases

@yuriolisa yuriolisa requested a review from pavolloffay June 7, 2022 13:47
@pavolloffay
Copy link
Member

To move this forward we have to be confident that e.g. OTEL operator v0.33.0 works well with all cert-manager versions that have v1alpha2 kind (e.g. the oldest and newest). Are we confident? If no, then we should be rather explicit and keep the established approach.

@yuriolisa
Copy link
Contributor Author

@pavolloffay, yes, we are confident that v1alpha2 is compatible with v0.33.0, since tested on that release the cert-manager v1.4.3 which deploys the v1alpha2 API version. As you could see in the following link:

opentelemetry-operator/Makefile

Line 137 in 402be27

kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.4.3/cert-manager.yaml

@pavolloffay
Copy link
Member

Let's give it a try then :)

@pavolloffay pavolloffay merged commit eccfb67 into open-telemetry:main Jun 8, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@yuriolisa
Bump cert manager to 1.8.0 (open-telemetry#905)
43a7fcb 
* Add Yuri Oliveira as Operator Approver

Signed-off-by: Yuri Sa <[email protected]>

* Add compatibility with cert-manager 1.8.0

Signed-off-by: Yuri Sa <[email protected]>

* Including Cert-Manager Kind Versions

* Add compatibility with cert-manager 1.6.3

Signed-off-by: Yuri Sa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuriolisa @pavolloffay