Fix docker multiarch build for operator #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
devops-42
approved these changes
May 19, 2022
Signed-off-by: Pavol Loffay <[email protected]>
frzifus
reviewed
May 19, 2022
| @@ -17,7 +17,6 @@ COPY internal/ internal/ | |||
| COPY pkg/ pkg/ | |||
| COPY versions.txt versions.txt | |||
|
|
|||
| ARG TARGETARCH=amd64 | |||
There was a problem hiding this comment.
Suggested change
| ARG TARGETARCH=amd64 | |
| ARG TARGETARCH |
would it make sense to remove =amd64?
There was a problem hiding this comment.
Then we would have to pass the arch as argument which should not be necessary
There was a problem hiding this comment.
But without we are not able to build it for a different target architecture, right?
There was a problem hiding this comment.
we are via docker buildx
Signed-off-by: Pavol Loffay <[email protected]>
VineethReddy02
approved these changes
May 24, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Fix docker multiarch build for operator Signed-off-by: Pavol Loffay <[email protected]> * Fix docker multiarch build for operator Signed-off-by: Pavol Loffay <[email protected]> * Fix multiarch build for TA Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Resolves #874