Add creation of ServiceAccount to the Target Allocator #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Apr 25, 2022
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+26
to
+32
| func ServiceAccountName(instance v1alpha1.OpenTelemetryCollector) string { | ||
| if len(instance.Spec.TargetAllocator.ServiceAccount) == 0 { | ||
| return naming.ServiceAccount(instance) | ||
| } | ||
|
|
||
| return instance.Spec.TargetAllocator.ServiceAccount | ||
| } |
There was a problem hiding this comment.
This matches what is done for the collector
secustor
requested changes
Apr 26, 2022
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
erichsueh3
reviewed
Apr 27, 2022
…or into target-allocator-service-account
erichsueh3
approved these changes
Apr 28, 2022
secustor
approved these changes
Apr 28, 2022
|
@Aneurysm9 Could you restart the pipeline as discussed here. https://cloud-native.slack.com/archives/C033BJ8BASU/p1651593666172049?thread_ts=1650910340.666659&cid=C033BJ8BASU Thanks! |
…or into target-allocator-service-account
|
Maybe @pavolloffay can review/merge this one, as JP is out on parental leave? |
|
@carlosalberto, @secustor, I just restarted the jobs. |
pavolloffay
approved these changes
Jun 3, 2022
6 tasks
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…y#836) * Added the creation or linking of an existing service account to the target allocator * Fix test * Updated from feedback * Fixed test package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a service account for use by the target allocator. This will let a user of the targetallocator bind roles to it which will allow the allocator to run it's loop.
Closes #834