Check exposed svc ports

[yuriolisa]

Signed-off-by: Yuri Sa [email protected]

[x] Created function ConfigValidate which checks if the services are present in the pipeline set.
[x] Created unit test to validate the new function.
[x] Included validation on ConfigToReceiverPorts function to open only ports for enabled receivers.
[x] Changed config_to_ports_test.go:
- Fixing indentation.
- Included service spec in tested config string.

Resolves #257

[yuriolisa]

Resolves #257

[jpkrohling]

LGTM

[pavolloffay]

@yuriolisa CI failed

[yuriolisa]

@pavolloffay, CI is fixed.

[VineethReddy02]

@yuriolisa IMO The changes in this PR are a bit tricky in operator we should not care much about otel-collector config, i.e. which is internal to the collector & let collector deal with issues in the config like no service/pipelines, etc..., except for opening the respective ports based on the config. The ValidateConfig is adding more complexity on the operator end, which ideally shouldn't be part of operator with such complex evaluations.

cc @pavolloffay @jpkrohling

If the others feel this adds value and make sense in the operator end. I would definitely recommend @yuriolisa to add e2e tests with different config types to completely validate the corner cases.

[jpkrohling]

let collector deal with issues in the config like no service/pipelines

Correct, we should not fail or return errors when this happens, we should just ignore and continue. In this case, if there are no pipelines, there should be no ports being exposed.

[yuriolisa]

@jpkrohling , @VineethReddy02 , @pavolloffay . Could you please review it?

[jpkrohling]

LGTM, but would be good to have a review from a fresh pair of eyes. @pavolloffay, @VineethReddy02?

[jpkrohling]

@VineethReddy02, given the outcome of your previous review, would you also be able to take a look at this?