Add upgrade for Instrumentation kind #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
VineethReddy02
approved these changes
Nov 17, 2021
Signed-off-by: Pavol Loffay <[email protected]>
|
@jpkrohling this is ready for review? |
jpkrohling
reviewed
Nov 19, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package upgrade |
There was a problem hiding this comment.
Can you improve the test coverage?
There was a problem hiding this comment.
This is good enough, otherwise I would have to mock the k8s client or test the logging...
|
@jpkrohling any more comments apart from refactoring main and test coverage? |
|
@jpkrohling could we please move this PR forward? |
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Add upgrade procedure for Instrumentation Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add upgrade procedure for Instrumentation Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]> * Fix Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment only the Java image is being upgraded automatically.