Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for podSecurityContext #469

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add support for podSecurityContext #469

merged 1 commit into from
Nov 17, 2021

Conversation

ekarlso
Copy link
Contributor

@ekarlso ekarlso commented Oct 24, 2021

Fixes: #468

@ekarlso ekarlso requested review from a team and bogdandrutu October 24, 2021 16:15
pavolloffay
pavolloffay reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than reverting operator-sdk changes the PR looks good to me

bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
@VineethReddy02
Copy link
Contributor

VineethReddy02 commented Oct 26, 2021 •
edited
Loading

@ekarlso Thanks for adding podSecurityContext support!
Can you also add the podSecurityContext field to this doc (there is an ongoing effort to replace this with auto-generated docs from CRD spec)? This doc helps to understand what can be configured in otelcollector CR.

Also, do not forget to rebase the PR. :)

@ekarlso ekarlso force-pushed the add-podsecuritycontext branch from 763db45 to 921b83b Compare October 29, 2021 15:38
@VineethReddy02 VineethReddy02 mentioned this pull request Oct 30, 2021
Closed
@ekarlso ekarlso force-pushed the add-podsecuritycontext branch 3 times, most recently from b5acd86 to 33d331d Compare November 12, 2021 17:17
@ekarlso ekarlso force-pushed the add-podsecuritycontext branch from 33d331d to 146984a Compare November 12, 2021 18:59
VineethReddy02
VineethReddy02 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpkrohling jpkrohling merged commit 7814baf into open-telemetry:main Nov 17, 2021
@ekarlso ekarlso deleted the add-podsecuritycontext branch November 22, 2021 10:39
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@ekarlso
Add support for podSecurity (open-telemetry#469)
1637b84
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@ekarlso
Add support for podSecurity (open-telemetry#469)
580b3d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay left review comments

@VineethReddy02 VineethReddy02 VineethReddy02 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting podSecurityContext
4 participants
@ekarlso @VineethReddy02 @pavolloffay @jpkrohling