Add flags to override hardcoded images #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
jpkrohling
reviewed
Oct 5, 2021
main.go
Outdated
| pflag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.") | ||
| pflag.BoolVar(&enableLeaderElection, "enable-leader-election", false, | ||
| "Enable leader election for controller manager. "+ | ||
| "Enabling this will ensure there is only one active controller manager.") | ||
| pflag.StringVar(&collectorImage, "collector-image", "", "The default OpenTelemetry collector image. This image is used when no image is specified in the CustomResource.") |
There was a problem hiding this comment.
Shouldn't this have a default?
There was a problem hiding this comment.
The default images are hardcoded in the config package
.The config package hardcodes image name and sets the tag based on the version.
There was a problem hiding this comment.
I have made some changes and moved the logic to main. It looks better now and cleaner.
Signed-off-by: Pavol Loffay <[email protected]>
jpkrohling
approved these changes
Oct 5, 2021
Signed-off-by: Pavol Loffay <[email protected]>
|
Fixed failing tests. I had to add a default (dummy) image names to config used in the tests. |
jpkrohling
approved these changes
Oct 5, 2021
|
@jpkrohling can we get this in before 0.36.0 goes out? |
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Add flags to override hardcoded images Signed-off-by: Pavol Loffay <[email protected]> * Fix typos Signed-off-by: Pavol Loffay <[email protected]> * Remove version from config Signed-off-by: Pavol Loffay <[email protected]> * Fix tests Signed-off-by: Pavol Loffay <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add flags to override hardcoded images Signed-off-by: Pavol Loffay <[email protected]> * Fix typos Signed-off-by: Pavol Loffay <[email protected]> * Remove version from config Signed-off-by: Pavol Loffay <[email protected]> * Fix tests Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #447
Signed-off-by: Pavol Loffay [email protected]