Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e/smoke-ip-families test #3519

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

araiu
Copy link
Contributor

@araiu araiu commented Dec 6, 2024

Description:
Not setting an empty object for protocols will render the receivers with no protocols. This should align this test with the OpenTelemetryCollector definition present in other tests.

Currently this is failing with:

Error: invalid configuration: receivers::otlp: must specify at least one protocol when using the OTLP receiver

Not setting an empty object for protocols will render the receivers with no protocols.
This should align this test with the `OpenTelemetryCollector` definition present in other tests.
@araiu araiu requested a review from a team as a code owner December 6, 2024 10:02
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 6, 2024
@swiatekm
Copy link
Contributor

swiatekm commented Dec 6, 2024

Where are you seeing the failure? The tests at least appears to be succeeding on the main branch.

@araiu
Copy link
Contributor Author

araiu commented Dec 6, 2024

Where are you seeing the failure? The tests at least appears to be succeeding on the main branch.

Hi Mikołaj,
I was seeing this error in opentelemetry-helm-charts, but apparently there was just a label missing (open-telemetry/opentelemetry-helm-charts@6034a55) on the test operator deployment.

I guess we can close this PR or keep just to keep consistency among tests, e.g. node-selector-collector ?

@swiatekm
Copy link
Contributor

swiatekm commented Dec 6, 2024

Where are you seeing the failure? The tests at least appears to be succeeding on the main branch.

Hi Mikołaj, I was seeing this error in opentelemetry-helm-charts, but apparently there was just a label missing (open-telemetry/opentelemetry-helm-charts@6034a55) on the test operator deployment.

I guess we can close this PR or keep just to keep consistency among tests, e.g. node-selector-collector ?

Sure, we can merge this for consistency. I just wanted to make sure we didn't have any issues with our CI. Thanks for the fix!

@swiatekm swiatekm merged commit 781818b into open-telemetry:main Dec 6, 2024
38 of 39 checks passed
@araiu araiu deleted the fix/e2e-smoke-ip-families branch December 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants