Revert "Support configuring java runtime from configmap or secret (env.valueFrom)" #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v.valueF…" This reverts commit 2b36f0d.
swiatekm
approved these changes
Dec 3, 2024
pavolloffay
approved these changes
Dec 3, 2024
iblancasa
approved these changes
Dec 3, 2024
nicolastakashi
pushed a commit
to coralogix/opentelemetry-operator
that referenced
this pull request
Dec 5, 2024
…v.valueFrom)" (open-telemetry#3510) * Revert "Support configuring java runtime from configmap or secret (env.valueF…" This reverts commit 2b36f0d. * chlog (open-telemetry#3511)
nicolastakashi
pushed a commit
to coralogix/opentelemetry-operator
that referenced
this pull request
Dec 5, 2024
…v.valueFrom)" (open-telemetry#3510) * Revert "Support configuring java runtime from configmap or secret (env.valueF…" This reverts commit 2b36f0d. * chlog (open-telemetry#3511)
nicolastakashi
pushed a commit
to coralogix/opentelemetry-operator
that referenced
this pull request
Dec 5, 2024
…v.valueFrom)" (open-telemetry#3510) * Revert "Support configuring java runtime from configmap or secret (env.valueF…" This reverts commit 2b36f0d. * chlog (open-telemetry#3511)
swiatekm
added a commit
that referenced
this pull request
Dec 19, 2024
* Revert "Support configuring java runtime from configmap or secret (env.valueFrom)" (#3510) * Revert "Support configuring java runtime from configmap or secret (env.valueF…" This reverts commit 2b36f0d. * chlog (#3511) * [CHORE] changing log level Signed-off-by: Nicolas Takashi <[email protected]> * [CHORE] renaming method Signed-off-by: Nicolas Takashi <[email protected]> * [CHORE] adding change log entry Signed-off-by: Nicolas Takashi <[email protected]> * [CHORE] locking targets per job Signed-off-by: Nicolas Takashi <[email protected]> * Update .chloggen/discovering-target-async.yaml Co-authored-by: Mikołaj Świątek <[email protected]> * [REFACTORY] applying comments Signed-off-by: Nicolas Takashi <[email protected]> * [CHORE] adding mutex back Signed-off-by: Nicolas Takashi <[email protected]> --------- Signed-off-by: Nicolas Takashi <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]> Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3379
closes #3463