Fix service account is created even when one is specified in collector spec #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Nov 21, 2023
jaronoff97
requested changes
Nov 21, 2023
| @@ -45,12 +45,14 @@ func Build(params manifests.Params) ([]client.Object, error) { | |||
| manifestFactories = append(manifestFactories, []manifests.K8sManifestFactory{ | |||
| manifests.FactoryWithoutError(ConfigMap), | |||
| manifests.FactoryWithoutError(HorizontalPodAutoscaler), | |||
| manifests.FactoryWithoutError(ServiceAccount), | |||
There was a problem hiding this comment.
Could we instead just check this in the service account manifest? In the builder we would then return nil if service account is set
|
I wasn't sure if the test should be placed in service account manifest, so I simply added test to builder since we would like to check if the builder build service account manifest when specified, feel free to let me know your thoughts : > |
jaronoff97
approved these changes
Nov 24, 2023
pavolloffay
approved these changes
Nov 24, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…r spec (open-telemetry#2378) * add additional check before creating sa for collector * update builder test for collector * change check collector sa specified in sa manifest * add specified account test case to collector building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix service account is created even when one is specified in collector spec
Link to tracking Issue:
#2372