Disable configuration hot reload in target allocator #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
disable-hot-reload
branch
from
73a8ebd to
7bf77cb
Compare
frzifus
reviewed
Nov 16, 2023
jaronoff97
approved these changes
Nov 16, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a flag to control configuration hot reloading in target allocator. The flag is disabled by default, and the functionality is hence considered deprecated and slated for removal in an upcoming release.
I could've done an official feature flag, but the target allocator doesn't have support for feature flags, and I don't think it's necessary to add it just for this.
Link to tracking Issue: #2032
Testing:
Added a unit test for the flag.