Run the target allocator as non-root #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Leadbeater <[email protected]>
dgl
commented
Nov 14, 2023
| @@ -16,4 +16,7 @@ COPY --from=certificates /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-ce | |||
| # Copy binary built on the host | |||
| COPY bin/opampbridge_${TARGETARCH} ./main | |||
|
|
|||
| # "nonroot" | |||
| USER 65532:65532 | |||
There was a problem hiding this comment.
Note I used 65532 as it's the distroless nonroot user, which the main Dockerfile uses.
swiatekm
approved these changes
Nov 14, 2023
Signed-off-by: David Leadbeater <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Run the target allocator as non-root Signed-off-by: David Leadbeater <[email protected]> * Add issue to changelog Signed-off-by: David Leadbeater <[email protected]> --------- Signed-off-by: David Leadbeater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a
USERdirective to the Dockerfile so target allocator runs as non-root. This satisfies the restricted pod security standard.Link to tracking Issue:
Not sure one is needed, similar was done in #738.
Testing:
Built and ran the target allocator image.
Documentation:
n/a