[operator-opamp-bridge][chore]: Refactor OpAMPBridge Webhook #2288
Conversation
| @@ -137,7 +137,7 @@ webhooks: | |||
| namespace: system | |||
| path: /validate-opentelemetry-io-v1alpha1-opampbridge | |||
| failurePolicy: Fail | |||
| name: vopampbridge.kb.io | |||
| name: vopampbridgecreateupdate.kb.io | |||
There was a problem hiding this comment.
why did this name change?
There was a problem hiding this comment.
The change has been done considering the validation webhook configurations of Collector resource.
One webhook is for create & update operations (with failure policy as Fail) and another one is for delete operation (with failure policy as Ignore). Previously, by default there was a single webhook for all the operations.
| "github.com/go-logr/logr" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-operator/internal/config" | ||
|
|
There was a problem hiding this comment.
the structure of these imports is wrong, though idk why our linter isn't catching it...
There was a problem hiding this comment.
im going to leave this in for now, and then we can figure out why the linter isn't catching this in a follow up
There was a problem hiding this comment.
the structure of these imports is wrong, though idk why our linter isn't catching it...
Yeah. Sometimes, it throws error for correct import structure too.
Description:
This PR updates the OpAMPBridge Webhook code to make it consistent with the changes that are made in Collector webhook as a part of #2210.
Link to tracking Issue: NA
Testing: Tested locally.
Documentation: NA