Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpAMP Bridge to comply with its design #2277

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Update OpAMP Bridge to comply with its design #2277

merged 5 commits into from
Oct 26, 2023

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Oct 25, 2023 •
edited
Loading

Description:
Right now, the bridge doesn't entirely conform to the design, it didn't support an annotation for reporting on managed instances. The naming structure also didn't match the design here:

As part of the Bridge’s AgentToServer message, the effective configuration reported will be a map of a collector’s namespaced name (<namespace>/<otelcol-name>) to that collector’s CRD resource. This will let the server know what should exist in the cluster. This data can be used to enrich information received from the collector’s OpAMP extension by joining on the collector’s pool name.

Further, we also weren't allowing servers to send full CRDs, only specs (another inaccuracy)

Link to tracking Issue: #2131

Testing: Tests were updated to reflect the changes

@jaronoff97 jaronoff97 requested a review from a team October 25, 2023 17:16
swiatekm
swiatekm approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/operator-opamp-bridge/agent/agent_test.go Outdated Show resolved Hide resolved
@jaronoff97 jaronoff97 merged commit 55c5673 into open-telemetry:main Oct 26, 2023
26 checks passed
@jaronoff97 jaronoff97 deleted the update-opamp-bridge-spec branch October 26, 2023 15:20
@jaronoff97 jaronoff97 mentioned this pull request Oct 26, 2023
Closed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@jaronoff97
Update OpAMP Bridge to comply with its design (open-telemetry#2277)
d54165b 
* Update bridge to be spec compliant

* deep copy

* Add more tests

* Fix bork

* update test to be less annoying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaronoff97 @swiatekm