reset kubeconfig to empty string when using in-cluster config #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changexd
force-pushed
the
fix-TA-kubeconfig
branch
from
7378f49 to
04ff0e5
Compare
…-cluster config (open-telemetry#2262) Signed-off-by: Darren Wang <[email protected]>
changexd
force-pushed
the
fix-TA-kubeconfig
branch
from
04ff0e5 to
16d835c
Compare
changexd
force-pushed
the
fix-TA-kubeconfig
branch
from
939948a to
71d8634
Compare
|
We're good to merge, see #2275 |
jaronoff97
approved these changes
Oct 25, 2023
|
Thank you for your contribution!! |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
reset kubeconfig to empty string when using in-cluster config
Link to tracking Issue:
#2262
Testing:
according to the discussion in #2262, it seems like we haven't added integration tests currently to check if prometheusCR and target allocator setup actually checks metrics. So I tested on my own cluster making sure the bug is fixed.
As this is my very first pull request and with lack of experience, I simply made changes with the solution provided in the issue, but if a helping hand is needed in adding integration tests, I would love to be part of it too!