[chore] Refactor Webhooks to their own packages

config/webhook/manifests.yaml

@@ -10,9 +10,9 @@ webhooks:
     service:
       name: webhook-service
       namespace: system
-      path: /mutate-opentelemetry-io-v1alpha1-instrumentation
+      path: /mutate-opentelemetry-io-v1alpha1-opentelemetrycollector
   failurePolicy: Fail
-  name: minstrumentation.kb.io
+  name: mopentelemetrycollector.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -22,17 +22,17 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - instrumentations
+    - opentelemetrycollectors
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /mutate-opentelemetry-io-v1alpha1-opentelemetrycollector
+      path: /mutate-opentelemetry-io-v1alpha1-instrumentation
   failurePolicy: Fail
-  name: mopentelemetrycollector.kb.io
+  name: minstrumentation.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -42,7 +42,7 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - opentelemetrycollectors
+    - instrumentations
   sideEffects: None
 - admissionReviewVersions:
   - v1
@@ -76,9 +76,9 @@ webhooks:
     service:
       name: webhook-service
       namespace: system
-      path: /validate-opentelemetry-io-v1alpha1-instrumentation
+      path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
   failurePolicy: Fail
-  name: vinstrumentationcreateupdate.kb.io
+  name: vopentelemetrycollectorcreateupdate.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -88,17 +88,17 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - instrumentations
+    - opentelemetrycollectors
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /validate-opentelemetry-io-v1alpha1-instrumentation
+      path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
   failurePolicy: Ignore
-  name: vinstrumentationdelete.kb.io
+  name: vopentelemetrycollectordelete.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -107,17 +107,17 @@ webhooks:
     operations:
     - DELETE
     resources:
-    - instrumentations
+    - opentelemetrycollectors
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
+      path: /validate-opentelemetry-io-v1alpha1-instrumentation
   failurePolicy: Fail
-  name: vopentelemetrycollectorcreateupdate.kb.io
+  name: vinstrumentationcreateupdate.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -127,17 +127,17 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - opentelemetrycollectors
+    - instrumentations
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
+      path: /validate-opentelemetry-io-v1alpha1-instrumentation
   failurePolicy: Ignore
-  name: vopentelemetrycollectordelete.kb.io
+  name: vinstrumentationdelete.kb.io
   rules:
   - apiGroups:
     - opentelemetry.io
@@ -146,5 +146,5 @@ webhooks:
     operations:
     - DELETE
     resources:
-    - opentelemetrycollectors
+    - instrumentations
   sideEffects: None

controllers/suite_test.go

@@ -49,6 +49,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-operator/internal/config"
 	"github.com/open-telemetry/opentelemetry-operator/internal/manifests"
 	"github.com/open-telemetry/opentelemetry-operator/internal/manifests/collector/testdata"
+	collectorwebhook "github.com/open-telemetry/opentelemetry-operator/internal/webhook/collector"
 	// +kubebuilder:scaffold:imports
 )
 
@@ -125,7 +126,7 @@ func TestMain(m *testing.M) {
 		os.Exit(1)
 	}
 
-	if err = (&v1alpha1.OpenTelemetryCollector{}).SetupWebhookWithManager(mgr); err != nil {
+	if err = collectorwebhook.SetupCollectorValidatingWebhookWithManager(mgr, config.New()); err != nil {
 		fmt.Printf("failed to SetupWebhookWithManager: %v", err)
 		os.Exit(1)
 	}