update usage of logging exporter #2130
Conversation
| @@ -48,21 +48,21 @@ spec: | |||
| timeout: 10s | |||
|
|
|||
| exporters: | |||
| logging: | |||
| debug: | |||
There was a problem hiding this comment.
Should reflect this in a changelog? @open-telemetry/operator-approvers
There was a problem hiding this comment.
yeah we should probably changelog this
There was a problem hiding this comment.
The PR changes just docs and e2e tests. Not sure why the changelog is needed. Users defining the logging exporter in their manifests will need to migrate explicitly.
@codeboten is the collector printing a warning if the logging exporter is used? The operator could parse the config and print a warning in the validating webhook.
There was a problem hiding this comment.
@pavolloffay if the logging exporter is used, it will print out a warning like this:
2023-09-29T08:00:43.970-0700 info exporter/exporter.go:275 Deprecated component. Will be removed in future releases. {"kind": "exporter", "data_type": "traces", "name": "logging"}
2023-09-29T08:00:43.970-0700 info exporter/exporter.go:275 Deprecated component. Will be removed in future releases. {"kind": "exporter", "data_type": "metrics", "name": "logging"}
2023-09-29T08:00:43.972-0700 info exporter/exporter.go:275 Deprecated component. Will be removed in future releases. {"kind": "exporter", "data_type": "logs", "name": "logging"}
There was a problem hiding this comment.
This deprecation warning appears for any components that are marked as deprecated
There was a problem hiding this comment.
this sounds like a good followup task, but something we can do later
codeboten
force-pushed
the
codeboten/logging-debug
branch
from
2abbabc to
eddb9bb
Compare
|
@codeboten you can update https://github.com/open-telemetry/opentelemetry-operator/blob/main/versions.txt#L5 to 0.86 which will use the latest collector. It should fix failing e2e tests. |
The logging exporter is being deprecated in favour of the debug exporter. This changes references to the logging exporter to use the new debug exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/logging-debug
branch
from
eddb9bb to
e5b6735
Compare
|
@pavolloffay rebased and bumped the version. Looks like there's still some failure. Will try to dig into them further |
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
|
@pavolloffay @jaronoff97 finally got around to fixing the tests. PTAL |
* update usage of logging exporter The logging exporter is being deprecated in favour of the debug exporter. This changes references to the logging exporter to use the new debug exporter instead. Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter. Signed-off-by: Alex Boten <[email protected]> * add changelog Signed-off-by: Alex Boten <[email protected]> * update collector version Signed-off-by: Alex Boten <[email protected]> * update expected data Signed-off-by: Alex Boten <[email protected]> * fix test expectations Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]>
The logging exporter is being deprecated in favour of the debug exporter. This changes references to the logging exporter to use the new debug exporter instead.
Note: this will remain in draft until v0.86.0 is released which will be the first release to include the debug exporter.