Set the securityContext for the HTTPD Apache instrumentation #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
reviewed
Aug 29, 2023
| @@ -145,7 +145,7 @@ func injectApacheHttpdagent(_ logr.Logger, apacheSpec v1alpha1.ApacheHttpd, pod | |||
| Command: []string{"/bin/sh", "-c"}, | |||
| Args: []string{ | |||
| // Copy agent binaries to shared volume | |||
| "cp -ar /opt/opentelemetry/* " + apacheAgentDirFull + " && " + | |||
There was a problem hiding this comment.
@chrlic could you please review?
|
#2069 is a blocker for this PR. |
Signed-off-by: Israel Blancas <[email protected]>
|
Blocked by #2225 |
|
CI failed |
pavolloffay
approved these changes
Oct 16, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…lemetry#2051) * Set the securityContext for the HTTPD Apache instrumentation Signed-off-by: Israel Blancas <[email protected]> * Fix unit tests Signed-off-by: Israel Blancas <[email protected]> * Add changelog Signed-off-by: Israel Blancas <[email protected]> --------- Signed-off-by: Israel Blancas <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2050 .