fix reconciliation error when prometheusremotewrite exporter is enabled #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1953 introduced the following error when prometheusremotewrite exporter is enabled failed to reconcile the expected deployments: failed to apply changes: Deployment.apps "cluster-collector" is invalid: spec.template.spec.containers[0].ports[3].containerPort: Required value" required configuration is: exporters: prometheusremotewrite: endpoint: "https://example.com/api/v1/write" getPrometheusExporterPorts() tries to parse this endpoint into a host:port pair, because the exporter name contains the string "prometheus", but prometheusremotewriteexporter's expected `endpoint` configuration is actually a URL, so that fails. additionally, due to a missing `continue` if the port parsing fails, an erroneous ContainerPort entry with port set to 0 is added to the configuration, causing the error. Signed-off-by: Lauri Tirkkonen <[email protected]>
ghost
self-requested a review
|
|
Looks like a duplicate of #2017, can you have a look and confirm @lauri-paypay ? |
|
@swiatekm-sumo you're right, it's duplicate. closing this one. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1953 introduced the following error when prometheusremotewrite exporter is enabled
required configuration is:
getPrometheusExporterPorts() tries to parse this endpoint into a host:port pair, because the exporter name contains the string "prometheus", but prometheusremotewriteexporter's expected
endpointconfiguration is actually a URL, so that fails. additionally, due to a missingcontinueif the port parsing fails, an erroneous ContainerPort entry with port set to 0 is added to the configuration, causing the error.