Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Reconciliation Flow #1995

Merged
merged 33 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6f3fe40
save
jaronoff97 Aug 3, 2023
29c0db7
bump
jaronoff97 Aug 7, 2023
72bb519
Merge branch 'main' of github.com:open-telemetry/opentelemetry-operat…
jaronoff97 Aug 7, 2023
80bc528
Merge branch 'main' of github.com:open-telemetry/opentelemetry-operat…
jaronoff97 Aug 7, 2023
6f8de85
:shrug:
jaronoff97 Aug 15, 2023
71a6a86
should b good
jaronoff97 Aug 16, 2023
d7347a7
change delete logic
jaronoff97 Aug 18, 2023
5064eb6
change error comparison
jaronoff97 Aug 18, 2023
81ad05e
Merge branch 'main' of github.com:jaronoff97/opentelemetry-operator i…
jaronoff97 Aug 18, 2023
084c404
gomod
jaronoff97 Aug 18, 2023
a0a8bef
Working status
jaronoff97 Aug 18, 2023
cc0f77d
remove cruft
jaronoff97 Aug 18, 2023
11b19b4
fix selector check for deepequals
jaronoff97 Aug 21, 2023
f011e1d
Merge branch 'main' of github.com:jaronoff97/opentelemetry-operator i…
jaronoff97 Aug 23, 2023
7e01b70
add controller references
jaronoff97 Aug 25, 2023
373e481
Merge branch 'main' into reconcile-change
jaronoff97 Aug 25, 2023
9606366
Fix lint and test
jaronoff97 Aug 25, 2023
9fe0f52
facepalm
jaronoff97 Aug 25, 2023
975cd3d
Record field
jaronoff97 Sep 5, 2023
d0fd750
Merge branch 'main' into reconcile-change
jaronoff97 Sep 11, 2023
d8f9100
Merge branch 'reconcile-change' of github.com:jaronoff97/opentelemetr…
jaronoff97 Sep 11, 2023
0d6115e
Fix diffing bug
jaronoff97 Sep 11, 2023
6e1b1fc
Add lots of tests
jaronoff97 Sep 12, 2023
2e522fd
Remove old logic entirely
jaronoff97 Sep 12, 2023
489e154
dont forget the kube builder
jaronoff97 Sep 12, 2023
2a54032
Merge branch 'main' into reconcile-change
jaronoff97 Sep 12, 2023
492a628
update comment, reusable builder
jaronoff97 Sep 13, 2023
a486cd6
respond to feedback
jaronoff97 Sep 13, 2023
2257714
Merge branch 'main' of github.com:open-telemetry/opentelemetry-operat…
jaronoff97 Sep 13, 2023
9bdd55c
update based on feedback
jaronoff97 Sep 18, 2023
a8b2f10
Merge branch 'main' of github.com:open-telemetry/opentelemetry-operat…
jaronoff97 Sep 18, 2023
4064374
update comments, remove method that does nothing
jaronoff97 Sep 19, 2023
dad4dc5
naming
jaronoff97 Sep 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .chloggen/reconcile-change.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Introduces a new method of reconciliation to reduce duplication and complexity

# One or more tracking issues related to the change
issues: [1959]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ spec:
- ""
resources:
- configmaps
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -132,46 +134,12 @@ spec:
verbs:
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- daemonsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- statefulsets
verbs:
- create
- delete
Expand All @@ -188,18 +156,6 @@ spec:
- get
- list
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- autoscaling
resources:
Expand Down
50 changes: 3 additions & 47 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ rules:
- ""
resources:
- configmaps
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -30,46 +32,12 @@ rules:
verbs:
- list
- watch
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- daemonsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- statefulsets
verbs:
- create
- delete
Expand All @@ -86,18 +54,6 @@ rules:
- get
- list
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- autoscaling
resources:
Expand Down
Loading
Loading