-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Add e2e test case for multi-cluster by exposing OTEL collector. #1956
Conversation
5e268ae
to
f282940
Compare
5e6583f
to
9c2e0fd
Compare
@IshwarKanse can you add this to the e2e.yml in the .github directory so this runs? |
@jaronoff97 This test requires a OpenShift cluster to run, it depends on several operators like Jaeger and cert-manager. Its still in WIP cause there are several issues we detected exposing the route for OTEL. I'll update the test case once the issues are fixed and will check if we can get it running on Kind clusters. |
Thanks for letting me know, i tagged Pavol on this PR as he has much more context on OpenShift things :) |
9c2e0fd
to
e708c7d
Compare
|
@frzifus @pavolloffay Can you review this test case. Since we cannot use two clusters, the test case simulates by creating the sender and receiver collector in two separate namespaces. *Sends traces to both OTLP HTTP and GRPC receiver exposed via route. |
e708c7d
to
41eb315
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks rly good to me @IshwarKanse!
Since we generate our own certificates and jaeger is deployed without the operator, what would be missing to run this test in this github ci too?
Primary the routes? The last time I checked, they have been installed for some tests too.
c2035fd
to
2e7822f
Compare
cc @frzifus @pavolloffay Can you help to reapprove and get this one merged. |
otlp: | ||
protocols: | ||
http: | ||
tls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use edge termination or insecure routes?
The recent version of the operator improved support for routes:
- hostname can be omitted
- the grpc route works for insecure and edge termination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay I have updated the test case to remove setting the hostname. But for setting custom certs, ran into this issue. https://issues.redhat.com/browse/TRACING-3609 For the time being, I've kept the termination as passthrough and using the custom certs.
148e61f
to
cbbdd2f
Compare
Adds e2e test case for multi-cluster by exposing OTEL collector.