-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[target-allocator] Addtl server unit tests #1357
Merged
pavolloffay
merged 5 commits into
open-telemetry:main
from
kristinapathak:improve-server-tests
Jan 25, 2023
Merged
[target-allocator] Addtl server unit tests #1357
pavolloffay
merged 5 commits into
open-telemetry:main
from
kristinapathak:improve-server-tests
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinapathak
force-pushed
the
improve-server-tests
branch
from
January 24, 2023 02:15
bafb0aa
to
4c0d3e3
Compare
jaronoff97
approved these changes
Jan 24, 2023
secustor
approved these changes
Jan 24, 2023
pavolloffay
approved these changes
Jan 25, 2023
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Jan 31, 2023
* add DiscoveryManager interface, ScrapeConfigsHandler tests * add job handler tests * add changelog entry * make LinkJSON with keyed fields * fix whitespace
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Feb 1, 2023
* add DiscoveryManager interface, ScrapeConfigsHandler tests * add job handler tests * add changelog entry * make LinkJSON with keyed fields * fix whitespace
frzifus
pushed a commit
to frzifus/opentelemetry-operator
that referenced
this pull request
Apr 15, 2023
* add DiscoveryManager interface, ScrapeConfigsHandler tests * add job handler tests * add changelog entry * make LinkJSON with keyed fields * fix whitespace
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* add DiscoveryManager interface, ScrapeConfigsHandler tests * add job handler tests * add changelog entry * make LinkJSON with keyed fields * fix whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests for correctness so I don't break anything 🙂 also added benchmarks
fixes #1392