Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped OpenTelemetry Collector to v0.16.0 #135

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

jpkrohling
Copy link
Member

Closes #134
Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling
Copy link
Member Author

@dengliming, if you have some time, would you like to review this one too?

@jpkrohling jpkrohling force-pushed the jpkrohling/134-update-otelcol-to-v0.16.0 branch from 32f47b1 to 53320c8 Compare December 3, 2020 16:32
@jpkrohling jpkrohling marked this pull request as draft December 3, 2020 19:20
@jpkrohling
Copy link
Member Author

Converting to draft, as I messed up the config for the OTLP. It's indeed correct to have the protocols node, with the protocol name in as a child.

@jpkrohling jpkrohling force-pushed the jpkrohling/134-update-otelcol-to-v0.16.0 branch from 53320c8 to 299fe5f Compare December 3, 2020 20:46
@jpkrohling jpkrohling marked this pull request as ready for review December 3, 2020 20:47
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling force-pushed the jpkrohling/134-update-otelcol-to-v0.16.0 branch from 299fe5f to 9518ae8 Compare December 3, 2020 20:47
Copy link
Member

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit 844ae6e into master Dec 4, 2020
@jpkrohling jpkrohling deleted the jpkrohling/134-update-otelcol-to-v0.16.0 branch December 4, 2020 12:27
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to collector v0.16.0
2 participants