Refactor the target allocator build to not run it as root #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
|
@jaronoff97 thanks for your review! I created #1346 to track this issue. There, you can see how I found the issue and how I checked everything was working properly after applying the changes from this PR. Please, let me know if further changes need to be done :) |
…or into run-ta-nonroot
Signed-off-by: Israel Blancas <[email protected]>
|
Thanks for making the issue! Could you add how you tested this to the description of the PR? |
|
@jaronoff97 done |
jaronoff97
approved these changes
Jan 5, 2023
frzifus
reviewed
Jan 5, 2023
4 tasks
Aneurysm9
reviewed
Jan 5, 2023
…or into run-ta-nonroot
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
approved these changes
Jan 9, 2023
This was referenced Feb 2, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…etry#1345) * Refactor the target allocator build to not run it as root Signed-off-by: Israel Blancas <[email protected]> * Add missing changelog Signed-off-by: Israel Blancas <[email protected]> * Fix issue number in changelog Signed-off-by: Israel Blancas <[email protected]> * Trigger Build Signed-off-by: Israel Blancas <[email protected]> * Use scratch image as base image for the target allocator Signed-off-by: Israel Blancas <[email protected]> Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Israel Blancas [email protected]
Fixes #1346
This change makes the target allocator being run as non root. The Dockerfile follows the same structure than the one from the OTEL Collector Operator.
Steps performed to ensure the issue is fixed
$ kubectl create namespace oteltest$ kubectl -n oteltest create rolebinding default-view-oteltest --role=pod-view --serviceaccount=oteltest:ta$ kubectl create -f tests/e2e/targetallocator-features/00-install.yaml -n oteltest:ta$ kubectl get pods -n oteltest)