-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default python exporters to use OTLP #1328
Update default python exporters to use OTLP #1328
Conversation
@TylerHelmuth shouldn't we use |
@mat-rumian sure I can make that change. |
0e0534e
to
b5a2fd0
Compare
Shall we as well change this comment in the requirements
So do I get it right that the exporter will use proto over HTTP and not gRPC? |
We didn't use |
615bdc3
to
e8c7252
Compare
@frzifus @pavolloffay @mat-rumian the e2e tests highlighted an interesting scenario that my code wasn't handling. Originally I was only setting the protocol when the exporter also needed set to I've updated the code to be less intelligent and always set the otlp protocol env var if it is not set. This env var is unncessary when the exporter is set to something other than Please re-review. |
e8c7252
to
f7a9077
Compare
* Update default python metrics exporter * Update sdk test * Update python to use `otlp` and OTEL_EXPORTER_OTLP_*_PROTOCOL * add changelog * Update e2e tests * Update how protocol is set
Closes #1168.
Updates the default exporters for python to use
otlp
andOTEL_EXPORTER_OTLP_[TRACES|METRICS]_PROTOCOL=http/protobuf
Depends on #1321