Remove default claims - fixes #1281 #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarlso
force-pushed
the
remove-default-claims
branch
from
c16b69f to
c9cb34d
Compare
ekarlso
force-pushed
the
remove-default-claims
branch
from
5e9c755 to
dc86570
Compare
pavolloffay
approved these changes
Nov 29, 2022
| @@ -76,11 +76,6 @@ func Container(cfg config.Config, logger logr.Logger, otelcol v1alpha1.OpenTelem | |||
|
|
|||
| if len(otelcol.Spec.VolumeMounts) > 0 { | |||
| volumeMounts = append(volumeMounts, otelcol.Spec.VolumeMounts...) | |||
| } else if otelcol.Spec.Mode == "statefulset" { | |||
There was a problem hiding this comment.
so the users will have to define the volumes explicitly in the CR?
I don't think we have even documented this default volume so not sure somebody used it.
There was a problem hiding this comment.
If you need a volume you're need to declare one to have one yes. Basically if not you Will always end up having PVCs / vols required that in some circumstances is not needed by default
|
thanks, merging this |
ihalaij1
pushed a commit
to ihalaij1/opentelemetry-operator
that referenced
this pull request
Dec 8, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1281