Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godoc for pod and container security context #1279

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Update godoc for pod and container security context #1279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f14899a
chore: update godoc for pod and container security context
jawnsy May 27, 2023
910092a
make bundle
jawnsy Aug 28, 2023
8ee95e5
re-run make api-docs
jawnsy Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ metadata:
categories: Logging & Tracing
certified: "false"
containerImage: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator
createdAt: "2023-08-18T14:30:49Z"
createdAt: "2023-08-28T17:54:06Z"
description: Provides the OpenTelemetry components, including the Collector
operators.operatorframework.io/builder: operator-sdk-v1.29.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
Expand Down
10 changes: 5 additions & 5 deletions bundle/manifests/opentelemetry.io_opentelemetrycollectors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3703,9 +3703,9 @@ spec:
attached to Collector and Target Allocator pods.
type: object
podSecurityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings. Some fields are also present in container.securityContext. Field
values of container.
description: PodSecurityContext configures the pod security context
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerHelmuth Running make bundle seemed to do the trick! I've checked in all the files except config/manager/kustomization.yaml as requested

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think the move was to run make bundle and then also run make api-docs. The tests were failing because I did the former but not the latter, and I think I've fixed that now.

@TylerHelmuth Can you please re-run the tests with 8ee95e5?

for the opentelemetry-collector pod, when running as a deployment,
daemonset, or statefulset.
properties:
fsGroup:
description: "A special supplemental group that applies to all
Expand Down Expand Up @@ -3928,8 +3928,8 @@ spec:
type: object
type: object
securityContext:
description: SecurityContext will be set as the container security
context.
description: SecurityContext configures the container security context
for the opentelemetry-collector container.
properties:
allowPrivilegeEscalation:
description: AllowPrivilegeEscalation controls whether a process
Expand Down
10 changes: 5 additions & 5 deletions config/crd/bases/opentelemetry.io_opentelemetrycollectors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3700,9 +3700,9 @@ spec:
attached to Collector and Target Allocator pods.
type: object
podSecurityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings. Some fields are also present in container.securityContext. Field
values of container.
description: PodSecurityContext configures the pod security context
for the opentelemetry-collector pod, when running as a deployment,
daemonset, or statefulset.
properties:
fsGroup:
description: "A special supplemental group that applies to all
Expand Down Expand Up @@ -3925,8 +3925,8 @@ spec:
type: object
type: object
securityContext:
description: SecurityContext will be set as the container security
context.
description: SecurityContext configures the container security context
for the opentelemetry-collector container.
properties:
allowPrivilegeEscalation:
description: AllowPrivilegeEscalation controls whether a process
Expand Down