Add new selector for pod and service monitor #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Nov 16, 2022
secustor
reviewed
Nov 16, 2022
kristinapathak
approved these changes
Nov 17, 2022
secustor
approved these changes
Nov 17, 2022
pavolloffay
approved these changes
Nov 18, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add new selector for pod and service monitor * Use map, add tests * Fix manifests * Fixed make * remove kustomization * Changed based on feedback * Docs * config whoops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1255 by adding in a pod and service monitor selector. I needed to change the signature of a few functions, but this is an otherwise minor change.
example:
the dip here is when i enabled a
release: testlabel selector for servicemonitors, and it comes back when i added the label back. The default behavior is the same as what it is now.