[target-allocator] create new target package #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Nov 1, 2022
| TargetURL: target.TargetURL, | ||
| Label: target.Label, | ||
| colOwner := c.consistentHasher.LocateKey([]byte(tg.Hash())) | ||
| targetItem := &target.Item{ |
There was a problem hiding this comment.
nit: can we use a target constructor to make this target.New
There was a problem hiding this comment.
Thanks for the review! This is a good point, changed!
| Link: LinkJSON{Link: fmt.Sprintf("/jobs/%s/targets", url.QueryEscape(target.JobName))}, | ||
| TargetURL: target.TargetURL, | ||
| Label: target.Label, | ||
| targetItem := &target.Item{ |
There was a problem hiding this comment.
nit: use constructor here too
kristinapathak
approved these changes
Nov 1, 2022
pavolloffay
approved these changes
Nov 1, 2022
secustor
approved these changes
Nov 1, 2022
moh-osman3
force-pushed
the
mohosman/issue-1213/create-new-target-package
branch
from
a306d06 to
ce039a9
Compare
moh-osman3
force-pushed
the
mohosman/issue-1213/create-new-target-package
branch
from
ce039a9 to
578a3c9
Compare
Aneurysm9
approved these changes
Nov 1, 2022
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1213