Using immutable labels as service selectors #1152
Conversation
|
CI failed |
There was a problem hiding this comment.
Could you please check the selector lebels in the e2e test ? ###
https://github.com/open-telemetry/opentelemetry-operator/blob/main/tests/e2e/smoke-simplest/00-assert.yaml#L43 and for the headless as well
pkg/collector/reconcile/service.go
Outdated
| // whereas 'labels' refers to the service | ||
| selector := labels | ||
| selector := collector.SelectorLabels(params.Instance) | ||
| selector["app.kubernetes.io/name"] = naming.Service(params.Instance) |
There was a problem hiding this comment.
Do we need this label? there is already "app.kubernetes.io/instance": naming.Truncate("%s.%s", 63, instance.Namespace, instance.Name),
angelokurtis
force-pushed
the
bugfix/image-update
branch
2 times, most recently
from
6e29f4f to
a014c63
Compare
We could add a check for all other selector labels, but I'm not sure if we could for What do you think? Any suggestion? |
|
@angelokurtis the upgrade tests are failing, can you look into them? |
angelokurtis
force-pushed
the
bugfix/image-update
branch
from
e5d4451 to
aae4f8d
Compare
* Using immutable labels as service selectors * Fixing expected service selectors * Removing unnecessary selector Co-authored-by: Vineeth Pothulapati <[email protected]>
fixes #1107