Change app image and context propagator b3 to b3multi in .Net e2e test case #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avadhut123pisal
changed the title
Kielek
approved these changes
Oct 10, 2022
| @@ -18,6 +18,6 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: myapp | |||
| image: docker.io/adib070/mvc | |||
| image: docker.io/avadhutp123/aspnetapp:latest | |||
There was a problem hiding this comment.
I do not like an idea to reference private repositories/docked hub repositories here. It should be hosted in scope of OTel/OTel-test dockerhub.
Probably candidate for separate issue.
There was a problem hiding this comment.
Could you please add a comment there with a link to the source code?
Could you please also book an issue to to use app that is hosted in OTEL org or in this repo?
There was a problem hiding this comment.
@pavolloffay Added the link to the source code repo and have raised the issue for consuming the apps that are hosted on OTEL org. #1155
pavolloffay
approved these changes
Oct 10, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…lemetry#1151) * changes app image and context propagator b3 to b3multi * adds source code repo link for the application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docker image of the application used in the e2e test case for .Net auto-instrumentation throws error due to some dependency related issues. This PR replaces that image with the new sample asp .Net application image.
Also, previously for e2e test cases for .Net auto-instrumentation, b3 propagator was configured. But, as per the opentelemetry-dotnet-instrumentation release v0.3.0-beta.1, supported propagators are
b3multi, baggage, tracecontext. So, with this PR b3 propagator is replaced with b3multi.