Enable instrumentation injecting only core SDK config #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pavolloffay
reviewed
Jul 25, 2022
README.md
Outdated
| You can configure the OpenTelemetry SDK for applications which can't | ||
| currently be autoinstrumented by using `inject-sdk` in place of (e.g.) | ||
| `inject-python` or `inject-java`. This will inject environment variables | ||
| like `OTEL_RESOURCE_ATTRIBUTES` but will not actually provide the SDK via an |
There was a problem hiding this comment.
via an init container
This is an implementation detail and it will not be true for e.g. Golang instrumentation. therefore it should not be mentioned here.
| name: sdk-only | ||
| spec: | ||
| env: | ||
| - name: OTEL_TRACES_EXPORTER |
There was a problem hiding this comment.
I would prefer to remove all this OTEL env vars rely on the env vars derived from the spec.
pavolloffay
changed the title
bilbof
force-pushed
the
main
branch
3 times, most recently
from
ce9eb98 to
8cf48ac
Compare
|
@pavolloffay thanks for your feedback, I've amended the commit |
pavolloffay
reviewed
Jul 26, 2022
README.md
Outdated
| Follow the instructions in the Dockerfiles on how to build a custom container image. | ||
|
|
||
| #### Inject OpenTelemetry SDK environment variables only | ||
|
|
||
| You can configure the OpenTelemetry SDK for applications which can't |
There was a problem hiding this comment.
nit we don't use line breaks in the readme.
README.md
Outdated
|
|
||
| You can configure the OpenTelemetry SDK for applications which can't | ||
| currently be autoinstrumented by using `inject-sdk` in place of (e.g.) | ||
| `inject-python` or `inject-java`. This will inject environment variables |
There was a problem hiding this comment.
We should mention as well reporter and sampling config.
Closes open-telemetry#990. Adds support for injecting SDK environment variables only, without injecting language-specific libraries or config. Usage: ```bash instrumentation.opentelemetry.io/inject-sdk: "true" ```
|
@pavolloffay thanks for reviewing. I've updated the readme and rebased. |
pavolloffay
approved these changes
Jul 27, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…#1000) Closes open-telemetry#990. Adds support for injecting SDK environment variables only, without injecting language-specific libraries or config. Usage: ```bash instrumentation.opentelemetry.io/inject-sdk: "true" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #990.
Adds support for injecting SDK environment variables only,
without injecting language-specific libraries or config.
Usage:
instrumentation.opentelemetry.io/inject-sdk: "true"