Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create serving certs for headless services on OpenShift #818

Closed
rkukura opened this issue Apr 12, 2022 · 2 comments · Fixed by #824
Closed

Create serving certs for headless services on OpenShift #818

rkukura opened this issue Apr 12, 2022 · 2 comments · Fixed by #824
Assignees
@rkukura
Labels
area:collector Issues for deploying collector enhancement New feature or request

Comments

@rkukura
Copy link
Contributor

rkukura commented Apr 12, 2022

When running on OpenShift, the opentelemetry-operator should include a service.beta.openshift.io/serving-cert-secret-name annotation in the headless services it creates for the collector. This will cause a certificate to be generated for the service and stored in a secret that can be mounted and used in the associated receiver TLS configuration.

Without this feature in the operator, it is necessary to either manage serving certificates manually, or add the annotation manually after deploying the collector. Until the annotation is added, the collector cannot start successfully because the secret being mounted as a volume does not yet exist.
@pavolloffay pavolloffay added area:collector Issues for deploying collector enhancement New feature or request labels Apr 14, 2022
@rkukura
Copy link
Contributor Author

rkukura commented Apr 14, 2022

@pavolloffay - Can you assign this to me? I expect to begin working on a PR today.

@pavolloffay
Copy link
Member

It's yours, no need to assign a comment is enough.

rkukura pushed a commit to rkukura/opentelemetry-operator that referenced this issue Apr 18, 2022
Create serving certs for headless services on OpenShift (open-telemet…
95cba71 
…ry#818)

Signed-off-by: Robert Kukura <[email protected]>
@rkukura rkukura mentioned this issue Apr 18, 2022
Merged
rkukura pushed a commit to rkukura/opentelemetry-operator that referenced this issue Apr 18, 2022
Create serving certs for headless services on OpenShift (open-telemet…
7fff13b 
…ry#818)

Add annotation to create serving cerfificates for services on OpenShift.

Resolves: open-telemetry#818

Signed-off-by: Robert Kukura <[email protected]>
rkukura pushed a commit to rkukura/opentelemetry-operator that referenced this issue Apr 21, 2022
Create serving certs for headless services on OpenShift (open-telemet…
12c02a2 
…ry#818)

Add annotation to create serving cerfificates for services on OpenShift.

Resolves: open-telemetry#818

Signed-off-by: Robert Kukura <[email protected]>
pavolloffay pushed a commit that referenced this issue Apr 26, 2022
Create serving certs for headless services on OpenShift (#818) (#824)
480f357 
Add annotation to create serving cerfificates for services on OpenShift.

Resolves: #818

Signed-off-by: Robert Kukura <[email protected]>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this issue May 1, 2024
Create serving certs for headless services on OpenShift (open-telemet…
307f815 
…ry#818) (open-telemetry#824)

Add annotation to create serving cerfificates for services on OpenShift.

Resolves: open-telemetry#818

Signed-off-by: Robert Kukura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkukura rkukura

Labels
area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create serving certs for headless services on OpenShift (#818) rkukura/opentelemetry-operator
2 participants
@rkukura @pavolloffay